Review Request 114574: KeepAwake plugin for KTp

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114574/#review53933
-----------------------------------------------------------


Thanks for the patch. Unfortunately I don't think this patch has a place in KTp. I can see many scenarios where people's laptops won't suspend unexpectedly, possibly burning down in their bags while running for the bus, resulting in angry (KDE) users. If you want to disable suspending/power management, there's already a checkbox for that in the battery plasmoid, which does precisely this. I don't want to have duplicated functionality around the system hidden in a user application that virtually all users would never think of being the cause of their broken suspend. Sorry.

I hate to trash the code and work that went into it; it helps if you talk to us about your ideas first :)

- Martin Klapetek


On March 23, 2014, 9:28 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114574/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 9:28 a.m.)
> 
> 
> Review request for Telepathy and Àlex Fiestas.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> KeepAwake plugin inhibits suspend for certain IM states. Also adds infrastructure for presence-responsive plugins.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d08606b 
>   config/telepathy-kded-config.cpp baaceff 
>   config/telepathy-kded-config.h 0400626 
>   config/telepathy-kded-config.ui 18f06f3 
>   keepawake.h PRE-CREATION 
>   keepawake.cpp PRE-CREATION 
>   telepathy-module.h 2213cdf 
>   telepathy-module.cpp 030a0d9 
> 
> Diff: https://git.reviewboard.kde.org/r/114574/diff/
> 
> 
> Testing
> -------
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140324/bc291402/attachment.html>