Review Request 116910: Use the newly moved PresenceModel from K-C-I

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116910/#review53481
-----------------------------------------------------------



dialogs/custom-presence-dialog.h
<https://git.reviewboard.kde.org/r/116910/#comment37603>

    Leave the "///" here, it's doxygen comment



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116910/#comment37599>

    Revert this change ;)



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116910/#comment37600>

    We generally prefer the "//" style comments for blocks smaller than ~6 lines, it's less "noisy"



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116910/#comment37601>

    Seems unneeded changes?



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116910/#comment37602>

    unrelated change


- Martin Klapetek


On March 19, 2014, 11:07 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116910/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 11:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> PresenceModel was moved from ktp-contact-list to ktp-common-internals. Using that.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.h c240682de128170682806bc3e6d7a0a6b0e7cf57 
>   global-presence-chooser.cpp 2a4ee7887fd62fdf12d7a702d86551f98b4e29d2 
>   presence-model.h d85e63d3de34ea80f2ec21f49acf46956239eca8 
>   presence-model.cpp c6ca099bf75fd5de6dfc7bb42f99284c4b110607 
>   dialogs/custom-presence-dialog.cpp 228a57cd1dadd0e5cb08231962324e4fd24326b8 
>   dialogs/custom-presence-dialog.h f48788a8742733245391788986cbfe916863b99e 
>   CMakeLists.txt 14eaf165f7c98fbfb0c36be62a5a1ec20b22b64c 
> 
> Diff: https://git.reviewboard.kde.org/r/116910/diff/
> 
> 
> Testing
> -------
> 
> Adding, removing presences work properly
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140320/804c8862/attachment-0001.html>