Review Request 116623: Removes duplication of call-ui window for a single channel.
Commit Hook
null at kde.org
Tue Mar 18 15:23:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116623/#review53333
-----------------------------------------------------------
This review has been submitted with commit b4626ae5b866464d9abfa2762b979224dbb4b589 by Martin Klapetek on behalf of mayank jha to branch kde-telepathy-0.8.
- Commit Hook
On March 6, 2014, 9:57 p.m., mayank jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116623/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 9:57 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 309146
> http://bugs.kde.org/show_bug.cgi?id=309146
>
>
> Repository: ktp-call-ui
>
>
> Description
> -------
>
> We store the channels handled by a callManager in a list, and upon a new request we check if it already exists, only if it is new we open a new call-ui window.
>
>
> Diffs
> -----
>
> src/call-handler.h 5fea003
> src/call-handler.cpp f4ced53
>
> Diff: https://git.reviewboard.kde.org/r/116623/diff/
>
>
> Testing
> -------
>
> Made a video call with another person. Clicked the audio and video call buttons. The window was not duplicated.
>
>
> Thanks,
>
> mayank jha
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140318/2c67e4d8/attachment.html>
More information about the KDE-Telepathy
mailing list