Review Request 116748: State-affinity custom status message <-> nowPlaying plugin bug

[Martin Klapetek]

> On March 12, 2014, 3:16 p.m., David Edmundson wrote:
> > "Fixes a state affinity issue where the contact list won't recognise a nowplaying plugin enable event when there is a custom status message set."
> > 
> > Can you explain why it won't be recognised? It will help me understand this patch.
> 
> James Smith wrote:
>     The current ordering of presences (as many as I can remember) in the kded plugin is as follows:
>     
>     b) plugin presences (w/ attached status messages)
>     c) user-set presences
>     
>     b) plugin presences (w/ attached status messages)
>     d) custom status message plugins
>     
>     c) user-set presences
>     d) custom status message plugins
>     
>     a) plugin presences
>     c) user-set presences
>     
>     d) custom status message plugins
>     a) plugin presences
> 
> David Edmundson wrote:
>     Then should the fix not be in this kded ordering?
> 
> David Edmundson wrote:
>     Especially as it looks like this was introduced by your last patch.
> 
> James Smith wrote:
>     It's probably easier to get right in the contact list, which currently additionally has hard to reproduce affinity glitches. The presence applet has to be taken into account, because someone can change to a custom status not knowing that the next track change in nowPlaying will necessarily overwrite the user-set presence. Also the advantages of the current code, such as leaving the status messages blank in the presence plugins to have the dynamic nowPlaying status message sticky when gone away / extended away are hard to re-implement. 
>     
>     https://git.reviewboard.kde.org/r/115425/ and this review are probably semi-related in scope.
>     
>     Is there a clean way to turn off nowPlaying and restore the original status message?

> someone can change to a custom status not knowing that the next track change in nowPlaying will necessarily overwrite the user-set presence

Which is why the nowplaying should be automatically disabled when that happens; if user knowingly changes his presence to anything he had configured before, he know he wants to have that presence now, therefore the nowplaying should just disable itself and not overwrite the presence anymore.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116748/#review52758
-----------------------------------------------------------


On March 13, 2014, 5:29 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116748/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 5:29 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 332082
>     http://bugs.kde.org/show_bug.cgi?id=332082
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Fixes a state affinity issue where the contact list won't recognise a nowplaying plugin enable event when there is a custom status message set.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/116748/diff/
> 
> 
> Testing
> -------
> 
> Compile, run-check.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140314/a13fd5dd/attachment.html>