Review Request 116707: KTp KDED Module: Implemented groups caching.
Alexandr Akulich
akulichalexander at gmail.com
Thu Mar 13 07:18:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116707/#review52867
-----------------------------------------------------------
contact-cache.cpp
<https://git.reviewboard.kde.org/r/116707/#comment37224>
Somehow there is missed type of "groupName" column. Query should be
"CREATE TABLE groups (groupId INTEGER, groupName VARCHAR);"
- Alexandr Akulich
On March 11, 2014, 3:19 p.m., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116707/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 3:19 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-kded-module
>
>
> Description
> -------
>
> Implemented in most simple and short way. I hope, there is no significant flaws.
>
>
> Diffs
> -----
>
> contact-cache.h 8fa6fac
> contact-cache.cpp 47fe0cd
>
> Diff: https://git.reviewboard.kde.org/r/116707/diff/
>
>
> Testing
> -------
>
> Working good.
>
>
> Thanks,
>
> Alexandr Akulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140313/ff2aa5d8/attachment.html>
More information about the KDE-Telepathy
mailing list