Review Request 116774: Integration with keyborad layout switcher, allow separate keyboard layout per chat tab.

Ahmed Ibrahim ahmedibrahimkhali at gmail.com
Wed Mar 12 22:41:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116774/
-----------------------------------------------------------

(Updated March 13, 2014, 12:41 a.m.)


Review request for Telepathy.


Changes
-------

Removed a trailing whitespace.


Bugs: 308953
    http://bugs.kde.org/show_bug.cgi?id=308953


Repository: ktp-text-ui


Description
-------

Used DBus interface to switch the keyboard layout and listen to the keyboard layout change. Stored the language in each ChatTab instance and then restore it back when the ChatWindow is activated and when switching between tabs.


Diffs (updated)
-----

  app/chat-window.h 793ac55 
  app/chat-window.cpp 2c2e12b 
  lib/chat-widget.h c1dbd41 
  lib/chat-widget.cpp e7c7619 

Diff: https://git.reviewboard.kde.org/r/116774/diff/


Testing
-------

Opened multiple ChatTabs and changed language of each one of them. When Switching between the tabs the language indicator is changed according to the language that is stored in the ChatTab.


Thanks,

Ahmed Ibrahim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140312/6bceb77f/attachment.html>


More information about the KDE-Telepathy mailing list