Review Request 116709: ktp-common-internals: Core: Tp::Connection::FeatureConnected added to ConnectionFactory options.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116709/#review52625
-----------------------------------------------------------

Ship it!


Awesome.
IMHO, this patch is better as it means we won't continually have people falling into this trap, and from what I can tell it won't cause any other slowdowns.

However, as maintainer of all the caching I'll let you pick which one we ship.

- David Edmundson


On March 11, 2014, 10:09 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116709/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 10:09 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> This patch fixes caching on onlineness changes.
> 
> 
> Diffs
> -----
> 
>   KTp/core.cpp 1898dc1 
> 
> Diff: https://git.reviewboard.kde.org/r/116709/diff/
> 
> 
> Testing
> -------
> 
> Works perfectly.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140311/0c46f0ef/attachment.html>