Review Request 116704: ktp-kded-module: Fixed caching.

[David Edmundson]

> On March 11, 2014, 8:48 a.m., David Edmundson wrote:
> > Ship it if you want, but I think there's an easier way.
> > 
> > IMHO it would be easier to use
> > connection->becomeReady(Connection::FeatureConnection) because then we can combine it with the becomeReady(roster) loading that's also here and drop the number of async things we're watching. 
> > 
> > Or we can probably add FeatureConnection to the default factories.
> > 
> >
> 
> Alexandr Akulich wrote:
>     Where I can add it? I have tried to change line 148 to "connection->becomeReady(Tp::Features() << Tp::Connection::FeatureRoster << Tp::Connection::FeatureConnected);", but it doesn't fix issue.

You would need to connect to the pendingOperation you get back finishing, and then running your onConnectionStatusChanged() when it finishes.
It's still needs the connecting for finished, but we might be able to group a few things together. Plus it has a slightly nicer API where we don't have to worry about making unique connections as calling becomeReady() twice will simply say finished() immediately the second time.

My alternate suggestion was to add it to the factory in CorePrivate::CorePrivate in ktp-common-internals. Then we don't need to add any async stuff here.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116704/#review52620
-----------------------------------------------------------


On March 11, 2014, 8:43 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116704/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 8:43 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> This patch fixes (for me) caching on onlineness changes.
> Without this patch caching happens only if accounts already online before module execution, which is usually not true. (was stucked on onAccountConnectionChanged)
> 
> 
> Diffs
> -----
> 
>   contact-cache.h 8fa6fac 
>   contact-cache.cpp 47fe0cd 
> 
> Diff: https://git.reviewboard.kde.org/r/116704/diff/
> 
> 
> Testing
> -------
> 
> After patch caching work just as planned.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140311/5c1ef47c/attachment.html>