Review Request 116623: Removes duplication of call-ui window for a single channel.
David Edmundson
david at davidedmundson.co.uk
Thu Mar 6 21:49:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116623/#review52303
-----------------------------------------------------------
Ship it!
There is quite a bit I want to add.
I'm happy for this to go in as a quick fix for 0.8 - at least we'll then have 1 change.
- David Edmundson
On March 6, 2014, 8:25 p.m., mayank jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116623/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 8:25 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 309146
> http://bugs.kde.org/show_bug.cgi?id=309146
>
>
> Repository: ktp-call-ui
>
>
> Description
> -------
>
> We store the channels handled by a callManager in a list, and upon a new request we check if it already exists, only if it is new we open a new call-ui window.
>
>
> Diffs
> -----
>
> src/call-handler.h 5fea003
> src/call-handler.cpp f4ced53
>
> Diff: https://git.reviewboard.kde.org/r/116623/diff/
>
>
> Testing
> -------
>
> Runs fine!
>
>
> Thanks,
>
> mayank jha
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140306/22b6ee4a/attachment.html>
More information about the KDE-Telepathy
mailing list