Review Request 116623: Removes duplication of call-ui window for a single channel.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116623/#review52226
-----------------------------------------------------------


This is good for what it is. The next part, the real challenge, is to activate the proper window, not just silently do nothing. Hint: you will need a new method in CallManager and something different than QList here in CallHandler.


src/call-handler.cpp
<https://git.reviewboard.kde.org/r/116623/#comment37013>

    QList has ::contains(..), which is preferred, also saves you fiddling with indexes ;)


- Martin Klapetek


On March 5, 2014, 11:38 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116623/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 11:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 309146
>     http://bugs.kde.org/show_bug.cgi?id=309146
> 
> 
> Repository: ktp-call-ui
> 
> 
> Description
> -------
> 
> We store the channels handled by a callManager in a list, and upon a new request we check if it already exists, only if it is new we open a new call-ui window.
> 
> 
> Diffs
> -----
> 
>   src/call-handler.cpp f4ced53 
>   src/call-handler.h 5fea003 
> 
> Diff: https://git.reviewboard.kde.org/r/116623/diff/
> 
> 
> Testing
> -------
> 
> Runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140306/7b3a3795/attachment.html>