Review Request 116607: Fixed astyle issues.

Martin Klapetek martin.klapetek at gmail.com
Wed Mar 5 08:51:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116607/#review52026
-----------------------------------------------------------



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116607/#comment36965>

    This seems wrong, it should be 
    
    Q_FOREACH (const Tp::AccountPtr &account, m_accountManager->allAccounts()) {



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116607/#comment36966>

    This is also wrong, it was correct before



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116607/#comment36967>

    Same here



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116607/#comment36968>

    Remove this, it will be replaced by your another patch (would cause troubles when merging)


- Martin Klapetek


On March 5, 2014, 9:47 a.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116607/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 9:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Fixed the coding style according to astyle script.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/116607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140305/4ac256e7/attachment-0001.html>


More information about the KDE-Telepathy mailing list