Review Request 116601: fixes the right to left position for global presence chooser widget edit button.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116601/#review52020
-----------------------------------------------------------


Looks good now, but as we will be committing this for you, please reupload a patch containing only your changes withtout the unrelated code style changes, these needs to be separated commits


global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36961>

    This is on purpose, it's called "normalisation", see http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/


- Martin Klapetek


On March 5, 2014, 9:03 a.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116601/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 9:03 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 319885
>     http://bugs.kde.org/show_bug.cgi?id=319885
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> As the values were hardcoded, so the changes were not reflected upon applying layout. Had to give the value for right to left.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/116601/diff/
> 
> 
> Testing
> -------
> 
> Tests fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140305/56e99111/attachment.html>