Review Request 116606: Adds an error dialog to provide information to the user.
Martin Klapetek
martin.klapetek at gmail.com
Wed Mar 5 07:47:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116606/#review52014
-----------------------------------------------------------
Message boxes are evil, we want to have a system notification (KNotification) to show up the error instead
src/handle-incoming-file-transfer-channel-job.cpp
<https://git.reviewboard.kde.org/r/116606/#comment36957>
I don't think this is needed
- Martin Klapetek
On March 5, 2014, 7:44 a.m., mayank jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116606/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 7:44 a.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 319025
> http://bugs.kde.org/show_bug.cgi?id=319025
>
>
> Repository: ktp-filetransfer-handler
>
>
> Description
> -------
>
> Adds a QMessageBox to display relevant error message.
>
>
> Diffs
> -----
>
> src/filetransfer-handler.cpp a5fa677
> src/handle-incoming-file-transfer-channel-job.cpp 36b8310
>
> Diff: https://git.reviewboard.kde.org/r/116606/diff/
>
>
> Testing
> -------
>
> Compiles fine! Test pending.
>
>
> Thanks,
>
> mayank jha
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140305/f92fd7fd/attachment-0001.html>
More information about the KDE-Telepathy
mailing list