Review Request 116601: fixes the right to left position for global presence chooser widget edit button.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116601/#review52008
-----------------------------------------------------------


Couple coding style issues, for future reference see http://techbase.kde.org/Policies/Kdelibs_Coding_Style - this is what we're using.


global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36949>

    if( -> if (



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36950>

    The inner indentation is 4 spaces



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36951>

    move( m.. -> move(m_ ...
    
    Also I don't think this is correct, it should move by the "offset" amount which is 22 (should be changed to not be a magic number at some point), not the button width (plus the comment above this line is wrong then).



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36952>

    height())/2) --> height()) / 2)



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36953>

    This goes on the same line



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36954>

    Why did you change from 22 to 32?


- Martin Klapetek


On March 5, 2014, 5:52 a.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116601/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 5:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 319885
>     http://bugs.kde.org/show_bug.cgi?id=319885
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> As the values were hardcoded, so the changes were not reflected upon applying layout. Had to give the value for right to left.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/116601/diff/
> 
> 
> Testing
> -------
> 
> Tests fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140305/ddbb49d9/attachment.html>