Review Request 116601: fixes the right to left position for global presence chooser widget edit button.

[David Edmundson]

> On March 4, 2014, 10:25 p.m., David Edmundson wrote:
> > Are you sure this is right? 
> > http://wstaw.org/m/2014/03/04/plasma-desktopDK3891.png looks miles away from where it should be, next to the arrow button.
> 
> mayank jha wrote:
>     the space left is for the spinner. Should I interchange the position of spinner and the button ? Or is there a scope for dynamic adjusting ?

AHA, it's because it's to the right of the spinner
http://wstaw.org/m/2014/03/04/plasma-desktopif3891.png

those two elements aren't being flipped and they're both always in LTR layout.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116601/#review51980
-----------------------------------------------------------


On March 4, 2014, 10:36 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116601/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 10:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 319885
>     http://bugs.kde.org/show_bug.cgi?id=319885
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> As the values were hardcoded, so the changes were not reflected upon applying layout. Had to give the value for right to left.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/116601/diff/
> 
> 
> Testing
> -------
> 
> Tests fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140304/daaf5d28/attachment.html>