Review Request 116601: fixes the right to left position for global presence chooser widget edit button.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116601/#review51964
-----------------------------------------------------------


It does not test fine:
http://wstaw.org/m/2014/03/04/plasma-desktopCP3891.png

For patches quality over quantity is always preferred.


global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36933>

    where does 1 come from?
    
    It's always good to avoid what we call "magic numbers". It's unreadable, and liable to break.
    
    There's an enum value for this.
    



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36934>

    Where on Earth does 235 come from?
    
    What if the user changes fonts? What if they resize the window? (see screenshot)
    
    
    



global-presence-chooser.cpp
<https://git.reviewboard.kde.org/r/116601/#comment36935>

    add braces {}


- David Edmundson


On March 4, 2014, 9:04 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116601/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 9:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 319885
>     http://bugs.kde.org/show_bug.cgi?id=319885
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> As the values were hardcoded, so the changes were not reflected upon applying layout. Had to give the value for right to left.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 2047473 
> 
> Diff: https://git.reviewboard.kde.org/r/116601/diff/
> 
> 
> Testing
> -------
> 
> Tests fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140304/349bb1ae/attachment.html>