Review Request 116560: Adds the feature to save the log files in the debugger.

[mayank jha]

> On March 3, 2014, 4:54 p.m., Martin Klapetek wrote:
> > Oh right, casting won't work because the hiearchy is 
> > 
> > KTabWidget
> > |
> > QWidget
> > |
> > DebugMessageView
> > 
> > ...so when you cast currentWidget(), it actually gives you the first QWidget. Not sure if we should fix that or not (as in make DebugMessageView the actual page widget leaving out the middle QWidget completely). 
> > 
> > Comments?
> > 
> > 
> > Otherwise I think now it's perfect, thank you.

Thanks for the explanation, Martin :D


- mayank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116560/#review51807
-----------------------------------------------------------


On March 3, 2014, 2:39 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116560/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 2:39 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 303564
>     http://bugs.kde.org/show_bug.cgi?id=303564
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Adds a button Save Log file to save the log in the currentTab of the TabWidget.
> 
> 
> Diffs
> -----
> 
>   tools/debugger/debug-message-view.h 49a4b2f 
>   tools/debugger/debug-message-view.cpp c2ead13 
>   tools/debugger/main-window.h 3876767 
>   tools/debugger/main-window.cpp faf7c22 
>   tools/debugger/main-window.ui 0813149 
> 
> Diff: https://git.reviewboard.kde.org/r/116560/diff/
> 
> 
> Testing
> -------
> 
> Runs fine!
> 
> 
> File Attachments
> ----------------
> 
> The Button added
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/03/e4d604cc-f67a-482a-9c81-0de3cbf3f2ea__savebutton.png
> The File Dialog Box
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/03/b6bb5033-dae3-4edc-bd60-f6428d9cfeda__savedialog.png
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140303/e3f7ac1c/attachment.html>