Review Request 116560: Adds the feature to save the log files in the debugger.

mayank jha mjnovice at gmail.com
Mon Mar 3 14:39:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116560/
-----------------------------------------------------------

(Updated March 3, 2014, 2:39 p.m.)


Review request for Telepathy.


Changes
-------

Thanks for the much needed suggestions. I agree with you all that switch case is not good here.
Martin: I tried type casting (QWidget *) to (DebugMessageView *) but it kept crashing, so I chose findChild() instead.


Bugs: 303564
    http://bugs.kde.org/show_bug.cgi?id=303564


Repository: ktp-common-internals


Description
-------

Adds a button Save Log file to save the log in the currentTab of the TabWidget.


Diffs (updated)
-----

  tools/debugger/debug-message-view.h 49a4b2f 
  tools/debugger/debug-message-view.cpp c2ead13 
  tools/debugger/main-window.h 3876767 
  tools/debugger/main-window.cpp faf7c22 
  tools/debugger/main-window.ui 0813149 

Diff: https://git.reviewboard.kde.org/r/116560/diff/


Testing
-------

Runs fine!


File Attachments
----------------

The Button added
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/03/e4d604cc-f67a-482a-9c81-0de3cbf3f2ea__savebutton.png
The File Dialog Box
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/03/b6bb5033-dae3-4edc-bd60-f6428d9cfeda__savedialog.png


Thanks,

mayank jha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140303/05cebc1f/attachment.html>


More information about the KDE-Telepathy mailing list