Review Request 116560: Adds the feature to save the log files in the debugger.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116560/#review51752
-----------------------------------------------------------


Looks quite good overall, thanks! Couple comments below.

Oh and pro tip - whenever you're doing any change to the UI, always attach a screenshot to the review, makes it easier to review ;)


tools/debugger/debug-message-view.cpp
<https://git.reviewboard.kde.org/r/116560/#comment36814>

    No space between function name and "("
    
    Also the string is a bit strange, I'd go with simple "Save log" or similar - be short and specific (what's "your file"?)



tools/debugger/main-window.h
<https://git.reviewboard.kde.org/r/116560/#comment36817>

    Don't mix camel case and underscores in method/var names



tools/debugger/main-window.cpp
<https://git.reviewboard.kde.org/r/116560/#comment36818>

    Spaces around all arguments



tools/debugger/main-window.ui
<https://git.reviewboard.kde.org/r/116560/#comment36815>

    This should be simple string, no html



tools/debugger/main-window.ui
<https://git.reviewboard.kde.org/r/116560/#comment36816>

    As we're not actually dealing with log files and "Save Log File" implies saving a log file, this string should be updated too, "Save log" is good or "Save Log into File"


- Martin Klapetek


On March 3, 2014, 9:44 a.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116560/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 9:44 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 303564
>     http://bugs.kde.org/show_bug.cgi?id=303564
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Adds a button Save Log file to save the log in the currentTab of the TabWidget.
> 
> 
> Diffs
> -----
> 
>   tools/debugger/debug-message-view.h 49a4b2f 
>   tools/debugger/debug-message-view.cpp c2ead13 
>   tools/debugger/main-window.h 3876767 
>   tools/debugger/main-window.cpp faf7c22 
>   tools/debugger/main-window.ui 0813149 
> 
> Diff: https://git.reviewboard.kde.org/r/116560/diff/
> 
> 
> Testing
> -------
> 
> Runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140303/5f59d87c/attachment.html>