Review Request 116520: Renames the label of the File Dialog Button from "Open" to "Send"

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116520/#review51726
-----------------------------------------------------------


Much much better, thanks! Note that same change needs to be done in ktp-contact-list/contact-list-widget.cpp line 498.


main.cpp
<https://git.reviewboard.kde.org/r/116520/#comment36803>

    Pointer sign goes to the variable name -> KFileDialog *dlg
    
    Also let's use proper variable names, we have autocompletion and storage is cheap, so no need to save on the var names. Makes the code more explicit and better readable (I suggest "fileDialog" but feel free to pick anything else).



main.cpp
<https://git.reviewboard.kde.org/r/116520/#comment36804>

    You need ->selectedUrls().
    
    Also delete the dialog after this using deleteLater().


- Martin Klapetek


On March 2, 2014, 11:24 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116520/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 11:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 331533
>     http://bugs.kde.org/show_bug.cgi?id=331533
> 
> 
> Repository: ktp-send-file
> 
> 
> Description
> -------
> 
> Modifies the label of FileDialog button from "Open" button to "Send".
> 
> 
> Diffs
> -----
> 
>   main.cpp a35c4e1 
> 
> Diff: https://git.reviewboard.kde.org/r/116520/diff/
> 
> 
> Testing
> -------
> 
> Runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140302/841fdcc6/attachment-0001.html>