Review Request 116520: Renames the label of the File Dialog Button from "Open" to "Send"

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116520/#review51657
-----------------------------------------------------------

Ship it!


Seems like you run astyle script only on sendfiledialog.cpp file.
Good job, though :).


sendfiledialog.h
<https://git.reviewboard.kde.org/r/116520/#comment36718>

    I think that this should be in sendfiledialog.cpp.



sendfiledialog.h
<https://git.reviewboard.kde.org/r/116520/#comment36727>

    Spacing is still wrong.
    * Add space between include directive and included file.
    * Add space before colon in class declaration.
    * Remove space after ampersand at "startDir" argument.



sendfiledialog.cpp
<https://git.reviewboard.kde.org/r/116520/#comment36731>

    You have long line (29), so why not move "parent" argument to previous line?
    Colon should be moved to lines with method signature as well.
    Just look at MainWindow constructor style.


Please, fix issues and ship it.

- Alexandr Akulich


On March 2, 2014, 1:15 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116520/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 1:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 331533
>     http://bugs.kde.org/show_bug.cgi?id=331533
> 
> 
> Repository: ktp-send-file
> 
> 
> Description
> -------
> 
> Creates a new widget which renames the "Open" button to "Send".
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 04ded76 
>   main.cpp a35c4e1 
>   sendfiledialog.h PRE-CREATION 
>   sendfiledialog.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116520/diff/
> 
> 
> Testing
> -------
> 
> Runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140302/3151b909/attachment.html>