Review Request 116520: Renames the label of the File Dialog Button from "Open" to "Send"

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116520/#review51500
-----------------------------------------------------------


Nice job.


sendfiledialog.h
<https://git.reviewboard.kde.org/r/116520/#comment36264>

    License



sendfiledialog.h
<https://git.reviewboard.kde.org/r/116520/#comment36266>

    ?



sendfiledialog.h
<https://git.reviewboard.kde.org/r/116520/#comment36265>

    I thought you were going to put this into ktp-common-internals/Widgets ?
    
    If you do, remember to add the namespace in here. Right now it's fine though



sendfiledialog.cpp
<https://git.reviewboard.kde.org/r/116520/#comment36269>

    license



sendfiledialog.cpp
<https://git.reviewboard.kde.org/r/116520/#comment36267>

    For spacing we follow this coding standard:
    http://techbase.kde.org/Policies/Kdelibs_Coding_Style
    
    Try to make sure the whole file follows this.



sendfiledialog.cpp
<https://git.reviewboard.kde.org/r/116520/#comment36268>

    This *needs* translating.
    i.e i18n("Send")


- David Edmundson


On March 1, 2014, 9:38 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116520/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 9:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 331533
>     http://bugs.kde.org/show_bug.cgi?id=331533
> 
> 
> Repository: ktp-send-file
> 
> 
> Description
> -------
> 
> Creates a new widget which renames the "Open" button to "Send".
> 
> 
> Diffs
> -----
> 
>   sendfiledialog.cpp PRE-CREATION 
>   sendfiledialog.h PRE-CREATION 
>   main.cpp a35c4e1 
>   CMakeLists.txt 04ded76 
> 
> Diff: https://git.reviewboard.kde.org/r/116520/diff/
> 
> 
> Testing
> -------
> 
> Runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140301/acad2a19/attachment-0001.html>