Review Request 118656: Fix for bug 333527 - added e-mail expansion to the url expansion filter.

Olaf Piesche opiesche at gmail.com
Sat Jun 14 18:19:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118656/
-----------------------------------------------------------

(Updated June 14, 2014, 6:19 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy.


Bugs: 333527
    http://bugs.kde.org/show_bug.cgi?id=333527


Repository: ktp-text-ui


Description
-------

Added e-mail recognition to the URL expansion filter as indicated in the bug. Maybe move to its own filter?

This does regex matching for e-mail addresses, replacing each with a mailto link. This works with an arbitrary number of e-mail addresses in a message, as long as the address is separated from the rest of the text.


Diffs
-----

  filters/urlexpansion/urlexpansion-filter.cpp b39dd5e 

Diff: https://git.reviewboard.kde.org/r/118656/diff/


Testing
-------

Sent multiple e-mail addresses in various configurations with and without text around them back and forth.


File Attachments
----------------

screen shot
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/11/652e641c-a8dd-4403-8de9-ecb24fc6a8ed__e-mail-expansion.jpg


Thanks,

Olaf Piesche

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140614/acf3e5bb/attachment.html>


More information about the KDE-Telepathy mailing list