Review Request 119112: Make the offline view a bit nicer
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jul 7 10:24:03 UTC 2014
> On July 7, 2014, 10:21 a.m., David Edmundson wrote:
> > contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml, line 53
> > <https://git.reviewboard.kde.org/r/119112/diff/1/?file=286959#file286959line53>
> >
> > Super noob question. A button is invisible it becomes disabled too, right?
You're afraid you'll still get to navigate to it even if hidden?
I would expect it to, I don't seem to get to it with tab at least.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119112/#review61791
-----------------------------------------------------------
On July 7, 2014, 10:11 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119112/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 10:11 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-desktop-applets
>
>
> Description
> -------
>
> Show the online icon above the "Go online" button.
>
> It feels less poor.
>
>
> Diffs
> -----
>
> contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 6319881
>
> Diff: https://git.reviewboard.kde.org/r/119112/diff/
>
>
> Testing
> -------
>
> I smiled back when looking at it.
>
>
> File Attachments
> ----------------
>
> kgc-font2.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/6c54b9c8-7650-47da-89fc-a3a0d1824777__kgc-font2.png
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140707/e3c18c33/attachment.html>
More information about the KDE-Telepathy
mailing list