Review Request 119085: Added disabling/enabling logging for entity

Dan Vrátil dvratil at redhat.com
Thu Jul 3 16:48:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119085/#review61568
-----------------------------------------------------------


Don't ship it (yet).


Either you must bump minimum required TelepathyLogger version in CMakeLists.txt, or this code must be #ifdefed

- Dan Vrátil


On July 3, 2014, 3:13 p.m., Marcin Ziemiński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119085/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 3:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: telepathy-logger-qt
> 
> 
> Description
> -------
> 
> Added simple wrappers of functions available in the master branch of telepathy-logger
> 
> 
> Diffs
> -----
> 
>   TelepathyLoggerQt4/log-manager.cpp 7aadc4d 
>   TelepathyLoggerQt4/log-manager.h 60a0e8c 
> 
> Diff: https://git.reviewboard.kde.org/r/119085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marcin Ziemiński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140703/f30d844c/attachment.html>


More information about the KDE-Telepathy mailing list