Review Request 119086: Added disabling/enabling logging for specified entities

[Dan Vrátil]

> On July 2, 2014, 2:21 p.m., David Edmundson wrote:
> > KTp/Logger/abstract-logger-plugin.h, line 167
> > <https://git.reviewboard.kde.org/r/119086/diff/1/?file=286655#file286655line167>
> >
> >     Dan, do we want these pure virtual or a base implementation that does nothing?

I think this is an optional feature, so I'm for having a base implementation that does nothing and always returns false.


> On July 2, 2014, 2:21 p.m., David Edmundson wrote:
> > KTp/Logger/abstract-logger-plugin.h, line 185
> > <https://git.reviewboard.kde.org/r/119086/diff/1/?file=286655#file286655line185>
> >
> >     When operation succeeds?
> 
> Marcin Ziemiński wrote:
>     When it succeeds in telepathy-logger-qt. It fails there if account is invalid.

As I already said in the tplqt review, I don't agree with the QVariant approach here. Just return bool and adjust the documentation accordingly.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119086/#review61477
-----------------------------------------------------------


On July 2, 2014, 2:05 p.m., Marcin Ziemiński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119086/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 2:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Added an option to disable or enable logging for entities with an implementation in tp-logger-plugin. 
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/abstract-logger-plugin.h 6db98d4 
>   KTp/Logger/log-manager.h c5f92d6 
>   KTp/Logger/log-manager.cpp 7ce4a12 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.h 346c233 
>   KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp 8c0cb16 
> 
> Diff: https://git.reviewboard.kde.org/r/119086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marcin Ziemiński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140702/4cbffc5b/attachment.html>