Review Request 119085: Added disabling/enabling logging for entity

[Marcin Ziemiński]

> On July 2, 2014, 12:20 p.m., David Edmundson wrote:
> > TelepathyLoggerQt4/log-manager.h, line 210
> > <https://git.reviewboard.kde.org/r/119085/diff/1/?file=286653#file286653line210>
> >
> >     why not just a bool?

If it fails false value would be misleading. 


- Marcin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119085/#review61476
-----------------------------------------------------------


On July 2, 2014, 11:59 a.m., Marcin Ziemiński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119085/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 11:59 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: telepathy-logger-qt
> 
> 
> Description
> -------
> 
> Added simple wrappers of functions available in the master branch of telepathy-logger
> 
> 
> Diffs
> -----
> 
>   TelepathyLoggerQt4/log-manager.h 60a0e8c 
>   TelepathyLoggerQt4/log-manager.cpp 7aadc4d 
> 
> Diff: https://git.reviewboard.kde.org/r/119085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marcin Ziemiński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140702/813919a4/attachment.html>