Review Request 119064: Add a "Go online" button when offline

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 2 00:30:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119064/
-----------------------------------------------------------

(Updated July 2, 2014, 12:30 a.m.)


Review request for Telepathy.


Changes
-------

Changed strategy to set the presence, using GlobalPresence::setPresence. Now it will specifically set to "online" instead of using the first available presence in the model, which was arguably random, anyway.

Still works, doesn't use the API david doesn't like.


Repository: ktp-desktop-applets


Description
-------

We're showing an empty view when we're offline. This should be improved, so I took the fast and simple approach first.


Diffs (updated)
-----

  contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 826465a 

Diff: https://git.reviewboard.kde.org/r/119064/diff/


Testing
-------

It's simple and it works. I like it.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140702/8600ad97/attachment.html>


More information about the KDE-Telepathy mailing list