Review Request 119063: Fix GlobalPresence metatype

[Aleix Pol Gonzalez]

> On July 1, 2014, 7:34 p.m., David Edmundson wrote:
> > KTp/global-presence.h, line 51
> > <https://git.reviewboard.kde.org/r/119063/diff/1/?file=285917#file285917line51>
> >
> >     If this is for master this is going to break lots of things. Be sure to update all of them too.
> >     (inc active)
> 
> Aleix Pol Gonzalez wrote:
>     Well, you decide if it goes to master I only want it for frameworks, but note there were 2 properties named the same and the behavior is undefined there (take another look at the line and the line above).
>     
>     Anyway, this is unrelated to the actual patch, so if you don't want to fix this, I can scrap this change.
>
> 
> David Edmundson wrote:
>     I do want this change (hence the ship it!), I'm rather horrified it got in in the first place. 
>     
>     I'm fine with master as long as we check before 0.9.0 that it doesn't break anything.
>     (unrelated: I'm surprised we don't get a tonne of runtime warnings for this)

I'm surprised moc eats it up. I guess they result in the same property...
Anyway, I'll push this to master and hope the QA team will go all Q :).

I added a personal todo task to add this check in Qt.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119063/#review61424
-----------------------------------------------------------


On July 1, 2014, 2:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119063/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 2:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Exposes the enum so it can be used from the plasmoid.
> 
> Also fixes a property name (copy paste bug?)
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.h dd20d46 
> 
> Diff: https://git.reviewboard.kde.org/r/119063/diff/
> 
> 
> Testing
> -------
> 
> Used it from https://git.reviewboard.kde.org/r/119064/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140701/908ef579/attachment.html>