Review Request 119063: Fix GlobalPresence metatype

[Aleix Pol Gonzalez]

> On July 1, 2014, 7:34 p.m., David Edmundson wrote:
> > KTp/global-presence.h, line 51
> > <https://git.reviewboard.kde.org/r/119063/diff/1/?file=285917#file285917line51>
> >
> >     If this is for master this is going to break lots of things. Be sure to update all of them too.
> >     (inc active)

Well, you decide if it goes to master I only want it for frameworks, but note there were 2 properties named the same and the behavior is undefined there (take another look at the line and the line above).

Anyway, this is unrelated to the actual patch, so if you don't want to fix this, I can scrap this change.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119063/#review61424
-----------------------------------------------------------


On July 1, 2014, 2:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119063/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 2:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Exposes the enum so it can be used from the plasmoid.
> 
> Also fixes a property name (copy paste bug?)
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.h dd20d46 
> 
> Diff: https://git.reviewboard.kde.org/r/119063/diff/
> 
> 
> Testing
> -------
> 
> Used it from https://git.reviewboard.kde.org/r/119064/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140701/0533ff3a/attachment.html>