Review Request 115328: KTp-KDED: Save all persistent information on a contact to a database

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115328/#review48378
-----------------------------------------------------------



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115328/#comment34209>

    This always goes on the same line
    
    Also I think you can use only the connect, it will call the slot immediately if it's ready, so no need for an extra check + we do it that way everywhere else :)



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115328/#comment34210>

    even one-line ifs have {}



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115328/#comment34211>

    If we're not using the argument, make the slot without it



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115328/#comment34212>

    imho it's not very good to have "bool onNewAccount" - it's not really clear why it returns bool from "onNewAccount" - does false mean that the new account was not created? does true mean that it is really new account that Telepathy didn't know about? It's just weird API


- Martin Klapetek


On Jan. 27, 2014, 12:52 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115328/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 12:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Was: https://git.reviewboard.kde.org/r/115060/
> 
> Draft version. Not proposed to be merged as is.
> 
> TODO:
> * Fix code
> * Add groups info
> * Performance testing.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp a754283 
>   contactnotify.cpp 314d48a 
>   contact-cache.h PRE-CREATION 
>   contact-cache.cpp PRE-CREATION 
>   CMakeLists.txt a31245b 
> 
> Diff: https://git.reviewboard.kde.org/r/115328/diff/
> 
> 
> Testing
> -------
> 
> Tested accounts contact refreshing in follow action:
> 1 Does connect via Telepathy.
> 2 Checked that contacts added to db (via sqlite db viewer).
> 3 Disconnected in telepathy.
> 4 Connect via another IM software.
> 5 Removed few contacts.
> 6 Does connect via Telepathy.
> 7 Checked that there is only actual contacts in db (via sqlite db viewer).
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140127/8aefb069/attachment-0001.html>