Review Request 115233: libKPeople: Draft version of SkypeDataSource

[Alexandr Akulich]

> On Jan. 22, 2014, 11:42 p.m., David Edmundson wrote:
> > src/plugins/skype/skypedatasource.cpp, line 3
> > <https://git.reviewboard.kde.org/r/115233/diff/1/?file=235301#file235301line3>
> >
> >     I don't remember writing this...

Omg! I surely remember to change this one! It should be result of some strange later merge :-D


> On Jan. 22, 2014, 11:42 p.m., David Edmundson wrote:
> > src/plugins/skype/skypedatasource.cpp, line 66
> > <https://git.reviewboard.kde.org/r/115233/diff/1/?file=235301#file235301line66>
> >
> >     obviously we can't merge like this.

This version isn't pretend to be merged as is. It's just draft to simplify review process (and some kind of reminder).


> On Jan. 22, 2014, 11:42 p.m., David Edmundson wrote:
> > src/plugins/skype/skypedatasource.cpp, line 182
> > <https://git.reviewboard.kde.org/r/115233/diff/1/?file=235301#file235301line182>
> >
> >     This if isn't needed anymore

Likely you're right.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115233/#review48065
-----------------------------------------------------------


On Jan. 22, 2014, 11:19 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115233/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 11:19 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Martin Klapetek.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Initial version of SkypeDataSource plugin.
> UI for account selection is not yet implemented, so in current state plugin doesn't works. (You can edit skypedatasource.cpp:67 and manualy set your account)
> 
> 
> Diffs
> -----
> 
>   src/plugins/CMakeLists.txt 3633676 
>   src/plugins/skype/CMakeLists.txt PRE-CREATION 
>   src/plugins/skype/skype_kpeople_plugin.desktop PRE-CREATION 
>   src/plugins/skype/skypedatasource.h PRE-CREATION 
>   src/plugins/skype/skypedatasource.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140122/bb280bf0/attachment-0001.html>