Review Request 115076: Display nice UI when no accounts are present

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115076/#review47623
-----------------------------------------------------------


I know where you took that from :P
Nice to see more and more KCMs adapting this style.

I'd suggest to hide all the items in the KCM (the anyways disabled edit/delete buttons and the listview) and just display the info widget - this gives it a much cleaner look, similar to what print-manager does when there are no printers, and then it wouldn't be duplication having this "Click here to add an account" button

- Kai Uwe Broulik


On Jan. 17, 2014, 2:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115076/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 2:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-accounts-kcm
> 
> 
> Description
> -------
> 
> Display nice UI when no accounts are present, see screenshot
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt cf7998e 
>   src/accounts-list-view.h PRE-CREATION 
>   src/accounts-list-view.cpp PRE-CREATION 
>   src/kcm-telepathy-accounts.cpp c8b837b 
>   src/main-widget.ui 4983c71 
> 
> Diff: https://git.reviewboard.kde.org/r/115076/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> kcm.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/17/2880d55c-2c75-4706-9694-ef25fdd92f47__kcm.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140118/105487d6/attachment.html>