Review Request 114569: Fix delayed status update for KTp

Martin Klapetek martin.klapetek at gmail.com
Thu Jan 16 14:33:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114569/#review47508
-----------------------------------------------------------

Ship it!


Thanks for that


telepathy-module.cpp
<https://git.reviewboard.kde.org/r/114569/#comment33769>

    Our coding style is "always add braces; even for one liners" --> 
    
    if () {
    ...
    } else {
    ...
    }


- Martin Klapetek


On Jan. 16, 2014, 6:02 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114569/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 6:02 a.m.)
> 
> 
> Review request for Telepathy and Xuetian Weng.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Fixes bug where state changes are slow to be returned to user-set values after autoaway / screensaveraway interruption.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp 19604bb 
> 
> Diff: https://git.reviewboard.kde.org/r/114569/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140116/f18bfa78/attachment-0001.html>


More information about the KDE-Telepathy mailing list