Review Request 115029: Moving ContactGridWidget to ContactViewWidget and providing access to view mode of the ListView

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115029/#review47506
-----------------------------------------------------------

Ship it!


Looks good, thanks.


KTp/Widgets/contact-grid-widget.h
<https://git.reviewboard.kde.org/r/115029/#comment33768>

    Change this to you.
    
    And in the .cpp file too


- David Edmundson


On Jan. 16, 2014, 8:22 a.m., Amandeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115029/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 8:22 a.m.)
> 
> 
> Review request for Telepathy and George Kiagiadakis.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> ContactGridWidget uses a QListView and sets its view mode to IconMode in the constructor. The existing class was renamed to ContactViewWidget which now provides method to get and set ViewModes.
> 
> ContactGridWdiget inherits this new class ContactViewWidget and sets the mode to IconMode to provide a grid-view as before.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/CMakeLists.txt 8c42029 
>   KTp/Widgets/contact-grid-widget.h 8421b31 
>   KTp/Widgets/contact-grid-widget.cpp 284f9fc 
>   KTp/Widgets/contact-view-widget.h PRE-CREATION 
>   KTp/Widgets/contact-view-widget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115029/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Amandeep Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140116/057866f5/attachment.html>