Review Request 114993: Resize notification bubble to fit text for large number of unread messages

David Edmundson david at davidedmundson.co.uk
Wed Jan 15 17:30:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114993/#review47461
-----------------------------------------------------------



chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml
<https://git.reviewboard.kde.org/r/114993/#comment33746>

    From theme.h this is wrong
    
                HighlightColor = 1, /**<  the text highlight color to be used by items resting
    
    Text and Highlight must both be visible on Background, but there's no guarantee that Text will be visible on Highlight.
    
    We need 
    font: theme.smallestFont


- David Edmundson


On Jan. 12, 2014, 11:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114993/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 11:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Resize notification bubble to fit text for large number of unread messages
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml b08235c 
> 
> Diff: https://git.reviewboard.kde.org/r/114993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140115/e28112c3/attachment-0001.html>


More information about the KDE-Telepathy mailing list