Review Request 115025: Don't display any favorite chat rooms if no account is online

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115025/#review47442
-----------------------------------------------------------

Ship it!



KTp/Widgets/join-chat-room-dialog.cpp
<https://git.reviewboard.kde.org/r/115025/#comment33742>

    I honestly can't tell if this is genius or madness.
    
    If you want a less hacky alternative you can do
    
    ui->listView->setModel(0);
    return;
    
    and then ui->listView->setModel(theProxy) in the else
    
    you decide. I'm happy with either


- David Edmundson


On Jan. 15, 2014, 12:23 p.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115025/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 12:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Don't display any favorite chat rooms if no account is online.
> 
> Not sure if this one-liner is too hacky, but I couldn't really find a much nicer way.
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/join-chat-room-dialog.cpp e84602020fd1a99052926515705adf6e4046c851 
> 
> Diff: https://git.reviewboard.kde.org/r/115025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140115/0ccd640a/attachment.html>