Review Request 115425: Activate / deactivate Now Playing globally in KConfig when setting playback status in the contact list

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115425/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 7:14 a.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

Fix contact list to not require a new string to enable mpris2 nowplaying with a custom message set. The code provided a dialog that would discourage enabling without an empty presence message set.

Wish: Can TelepathyQT at some point provide a method for clearing the status message that doesn't require constructing a brand-new presence devoid of a status message but with the existing attributes? setPresence.empty doesn't make much sense but setStatusMessage.empty() does. ;)

This string-less version should be good enough if necessary for .8 . There are still a few noted problems with kded interaction for the original list.


Repository: ktp-contact-list


Description
-------

Enables / disables Now Playing in systemsettings every time it is enabled / disabled in the contact list.

Fixes systemsettings kcm showing nowplaying enabled while the contact list has disabled its functionality.


Diffs (updated)
-----

  global-presence-chooser.h c240682 
  global-presence-chooser.cpp 2047473 

Diff: https://git.reviewboard.kde.org/r/115425/diff/


Testing
-------

Compile, run.


File Attachments
----------------

What the presence changer looks like
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/19/bff7b099-8e07-454d-a49a-f7151941645a__contactlistpresencechanger.png
What the custom status message dialog looks like
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/19/062d62a1-46a9-41e6-8144-9c16b330a2be__contactlistsorryactiveplugin.png


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140228/a83ea986/attachment.html>