Review Request 115943: Fixes duplication of groups when renaming it.

[mayank jha]

> On Feb. 27, 2014, 10:21 a.m., David Edmundson wrote:
> > I've been trying and I can't reproduce the original bug without this patch
> > How did you manage to do so?

I could see the bug, am using Linux Mint 15, 32-bit. I compiled it from source and then ran it. The bug is that the original group perisists to be in the widget showing 1 or 2 contacts, which somehow do not get transferred to the new group. 


- mayank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115943/#review51017
-----------------------------------------------------------


On Feb. 21, 2014, 8:24 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115943/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 8:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 329904
>     http://bugs.kde.org/show_bug.cgi?id=329904
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> This patch fixes, the group duplication upon renaming the group. This is probably due to the scheduling of the operations of adding and removing contacts from groups, so I separated the two, and it works fine!
> 
> 
> Diffs
> -----
> 
>   context-menu.cpp 00795d7 
> 
> Diff: https://git.reviewboard.kde.org/r/115943/diff/
> 
> 
> Testing
> -------
> 
> Testing Done, it works fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140228/f7a77ebf/attachment.html>