Review Request 116115: ktp-contact-list: Set application icon globally in aboutData, instead of in MainWidget only.
David Edmundson
david at davidedmundson.co.uk
Thu Feb 27 12:00:01 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116115/#review51036
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Feb. 27, 2014, 11:59 a.m., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116115/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 11:59 a.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 331491
> http://bugs.kde.org/show_bug.cgi?id=331491
>
>
> Repository: ktp-contact-list
>
>
> Description
> -------
>
> We have set special program icon for main widget, but help menu and possible other places uses KAboutData information, so try to set icon = appName.
>
>
> Diffs
> -----
>
> main-widget.cpp e4a9cda
> main.cpp 65801df
>
> Diff: https://git.reviewboard.kde.org/r/116115/diff/
>
>
> Testing
> -------
>
> All just fine. MainWidget and help menu have proper icons.
>
>
> Thanks,
>
> Alexandr Akulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140227/542ad19e/attachment.html>
More information about the KDE-Telepathy
mailing list