Review Request 115844: Add support for refresh of publish and subscription state

David Edmundson david at davidedmundson.co.uk
Thu Feb 27 10:11:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115844/#review51016
-----------------------------------------------------------

Ship it!


Ship it, but I guess this is rather pointless till we can merge 115842?


KTp/contact-info-dialog.cpp
<https://git.reviewboard.kde.org/r/115844/#comment35796>

    I'm not 1000% sure this is right, but it will be pretty obvious when we try it.
    


- David Edmundson


On Feb. 20, 2014, 9 p.m., Jan Stourac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115844/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 9 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> dialog does not show correct icon indicating publish/subscription state due to missing roster feature of connection...
> 
> 
> Diffs
> -----
> 
>   KTp/contact-info-dialog.h 2bf8a57 
>   KTp/contact-info-dialog.cpp 1e7087e 
> 
> Diff: https://git.reviewboard.kde.org/r/115844/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Stourac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140227/fdc75dc4/attachment.html>


More information about the KDE-Telepathy mailing list