Review Request 115844: Add support for refresh of publish and subscription state

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115844/#review50213
-----------------------------------------------------------



KTp/contact-info-dialog.cpp
<https://git.reviewboard.kde.org/r/115844/#comment35349>

    I'd rather not delete the widgets and re-add them if we can avoid it.
    
    Can we just change update the icon?



KTp/contact-info-dialog.cpp
<https://git.reviewboard.kde.org/r/115844/#comment35348>

    publish state and subscription state can be unknown for other reasons (like the CM not supporting it)
    
    Also some accounts don't support feature Roster (local-xmpp), which means this then  explodes unfortunately.
    
    I think we need
    
    if (connection->features() does not contain FeatureRoster && connection->supportedFeatures does contain FeatureRoster) {
       connection->becomeReady(...)
    }
    


- David Edmundson


On Feb. 17, 2014, 8:15 p.m., Jan Stourac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115844/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 8:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> dialog does not show correct icon indicating publish/subscription state due to missing roster feature of connection...
> 
> 
> Diffs
> -----
> 
>   KTp/contact-info-dialog.h 2bf8a57 
>   KTp/contact-info-dialog.cpp 1e7087e 
> 
> Diff: https://git.reviewboard.kde.org/r/115844/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Stourac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140219/aa007dbd/attachment.html>