Review Request 115499: Season of KDE Project - KRFB

[Amandeep Singh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115499/
-----------------------------------------------------------

(Updated Feb. 18, 2014, 2:43 p.m.)


Review request for Telepathy and George Kiagiadakis.


Changes
-------

- Made the UI flexible as desired
- Fixed a crash issue with pending clients
- Dialog's parents are corrected
- Only RfbServerManager's cleanup now tied to qApp's aboutToQuit, thus avoiding possible race condition.


Repository: krfb


Description
-------

Season of KDE Project - KRFB

Status Quo
-----------
Currently KRFB works on an invite-only model, where the host user needs to create an invite via the Invitation Dialog.
This provides the connection details (address and password), which must then be communicated to the remote user.
No information about telepathy contacts with whom desktop can be shared is present in the KRFB Dialog.
The implementation of RFB also lacks support of clipboard operations like cut and paste of text.

Changes
-------
Krfb modified to move away from invite-model, and modeled as a service that can be started/stopped.
Bidirectional text-clipboard operations are supported.
Telepathy contacts with rfb capability shown inside main window, with an option to share desktop.
Desktop sharing password visible in main window, with option to change it.
Unattended Access allowed with separate password.
Fixed bugs in libvncserver responsible for KRFB crashing.
Krfb now runs as KUniqueApplication.

All changes are present in the following clone of KRFB

Repository
----------
http://quickgit.kde.org/?p=clones%2Fkrfb%2Famandeepsingh%2Fkrfb-sok.git


Diffs (updated)
-----

  krfb/invitationsrfbclient.cpp bd5cff8 
  krfb/invitationsrfbserver.cpp 47ed934 
  krfb/mainwindow.cpp PRE-CREATION 
  krfb/rfbclient.h 7b46d3f 
  krfb/rfbclient.cpp 9ab16eb 
  krfb/rfbserver.cpp cd5d6c0 
  krfb/tubesrfbserver.cpp 575c3cd 
  krfb/ui/mainwidget.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115499/diff/


Testing
-------


Thanks,

Amandeep Singh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140218/6ac2c3e8/attachment.html>