Review Request 115834: Emit initialFetchComplete() from KTpAllContacts's Monitor

Dan Vrátil dvratil at redhat.com
Mon Feb 17 17:09:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115834/
-----------------------------------------------------------

(Updated Feb. 17, 2014, 6:09 p.m.)


Review request for Telepathy.


Changes
-------

- update the patch against current git master
- remove the ContactsListModel part of the patch, which was wrong


Bugs: 331146
    http://bugs.kde.org/show_bug.cgi?id=331146


Repository: ktp-common-internals


Description
-------

Follow up for review 115833.

This patch has two parts:

First fixes emission of modelInitialized() signal from ContactsListModel. Second emits initialFetchComplete() when KTpAllContacts' monitor fetches all contacts from contact manager.

This should go as two commits, but I'm too lazy to file two reviews for such small changes.


Diffs (updated)
-----

  kpeople/datasourceplugin/im-persons-data-source.cpp 3db1cde 

Diff: https://git.reviewboard.kde.org/r/115834/diff/


Testing
-------

Fixes bug 331146.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140217/0e9fe6c2/attachment.html>


More information about the KDE-Telepathy mailing list