Review Request 115828: Add a workaround for broken sorting

[David Edmundson]

> On Feb. 17, 2014, 3:47 p.m., Dan Vrátil wrote:
> > KTp/Models/contacts-filter-model.h, line 294
> > <https://git.reviewboard.kde.org/r/115828/diff/1/?file=244516#file244516line294>
> >
> >     I guess this should be Q_PRIVATE_SLOT.

It kinda should, except I can't use that without having a d_func() method. Which I don't have.

I could add one but writing one by hand is weird, and I can't use the Q_DECLARE_PRIVATE macro without changing all the names to d_ptr.


We are going to break ABI when we move to Qt5, and at that point I'll be removing this method anyway.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115828/#review50056
-----------------------------------------------------------


On Feb. 17, 2014, 12:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115828/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 12:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Add a workaround for broken sorting
> 
> There is a bug in QSortFilterProxyModel in which if sort() is called
> on a model where all items are filtered it will not start sorting
> as it cannot map the proxy column to the source column.
> 
> This gets updated whenever there's an insertRows but not from
> a dataChanged. With the kpeople cache this means that it's not sorting
> as we never do an insertRows.
> 
> This bug is fixed in Qt5.2, but not in 4.x
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-filter-model.h a891d6b 
>   KTp/Models/contacts-filter-model.cpp df12112 
> 
> Diff: https://git.reviewboard.kde.org/r/115828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140217/45ae3680/attachment.html>