Review Request 115425: Activate / deactivate Now Playing globally in KConfig when setting playback status in the contact list

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115425/
-----------------------------------------------------------

(Updated Feb. 15, 2014, 1:25 p.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

Turns the now playing entry into a toggle to enable / disable now playing.

The only caveat(s):

1) Until I can figure out how to return the current presence with an empty status message, custom user-set presences override status message plugins. So the now playing presence doesn't take effect immediately, but when the custom presence is cleared. The dialog box string is already unclear 'enable it and use as your presence' but I don't know if we absolutely need to annoy translators...

2) The speaker icon doesn't have affinity with the now playing presence message.

This ticket (with #114569) is a fairly high priority for the next release; the original patch left an empty now playing entry. This patch is a better situation and is functional, but the custom presence behavior needs a solution.


Repository: ktp-contact-list


Description
-------

Enables / disables Now Playing in systemsettings every time it is enabled / disabled in the contact list.

Fixes systemsettings kcm showing nowplaying enabled while the contact list has disabled its functionality.


Diffs (updated)
-----

  global-presence-chooser.cpp 2047473 

Diff: https://git.reviewboard.kde.org/r/115425/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140215/2dd58b63/attachment.html>