Review Request 115328: KTp-KDED: Save all persistent information on a contact to a database

[David Edmundson]

> On Feb. 6, 2014, 11:57 a.m., David Edmundson wrote:
> > tests/contact-cache-main.cpp, line 39
> > <https://git.reviewboard.kde.org/r/115328/diff/3/?file=242227#file242227line39>
> >
> >     What are these two lines for?
> 
> Alexandr Akulich wrote:
>     I have a lot of strange segfaults in deep of KTp::GlobalContactManager() constructor, in it's "connect" line. Now I'm working on different workstation and can't reproduce error.

[13:13] <d_ed> You're not even calling KTp::GCM, how can it be crashing there?
[13:13] <d_ed> remove them; it's a test - if there's a crash I want to know about it


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115328/#review49106
-----------------------------------------------------------


On Feb. 6, 2014, 11:51 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115328/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 11:51 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Was: https://git.reviewboard.kde.org/r/115060/
> 
> Draft version. Not proposed to be merged as is.
> 
> TODO:
> * Fix code
> * Add groups info
> * Performance testing.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a31245b 
>   contact-cache.h PRE-CREATION 
>   contact-cache.cpp PRE-CREATION 
>   contactnotify.cpp 314d48a 
>   telepathy-module.cpp a754283 
>   tests/CMakeLists.txt PRE-CREATION 
>   tests/contact-cache-main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115328/diff/
> 
> 
> Testing
> -------
> 
> Tested accounts contact refreshing in follow action:
> 1 Does connect via Telepathy.
> 2 Checked that contacts added to db (via sqlite db viewer).
> 3 Disconnected in telepathy.
> 4 Connect via another IM software.
> 5 Removed few contacts.
> 6 Does connect via Telepathy.
> 7 Checked that there is only actual contacts in db (via sqlite db viewer).
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140206/e4fbc9c8/attachment.html>