Review Request 115463: Fix for sending ini and exe files using Google Talk account
Martin Klapetek
martin.klapetek at gmail.com
Wed Feb 5 16:33:40 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115463/#review49050
-----------------------------------------------------------
data/ktelepathy.notifyrc
<https://git.reviewboard.kde.org/r/115463/#comment34639>
The wording should imho be "Sending exe or ini...", simillarily the comment should explain the user what this notification is for, so I'd suggest something like "Informs that the file sent was renamed because GoogleTalk (should be just Google? Gmail is blocked too) blocks some extensions"
- Martin Klapetek
On Feb. 5, 2014, 5:29 p.m., Jan Stourac wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115463/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 5:29 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 326786
> http://bugs.kde.org/show_bug.cgi?id=326786
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> each file transfer is checked for using google talk and forbidden extensions...in that case, "_" character is appended to suggested file name. for all other cases, transfer process remains the same.
>
>
> Diffs
> -----
>
> KTp/actions.cpp ec8a19e
> data/ktelepathy.notifyrc 1d2411d
>
> Diff: https://git.reviewboard.kde.org/r/115463/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Stourac
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140205/2a8c3e25/attachment.html>
More information about the KDE-Telepathy
mailing list