Review Request 115328: KTp-KDED: Save all persistent information on a contact to a database

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115328/#review49004
-----------------------------------------------------------

Ship it!



I know you have a tiny executable to run this without launching the kded, could you include this in the kded code in a tests folder so that it's easier for others to hack on this later. Do not install this app though.


contact-cache.h
<https://git.reviewboard.kde.org/r/115328/#comment34602>

    bool accountIsInteresting(const Tp::AccountPtr &account) const;
    
    (with additional const on the end)



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115328/#comment34600>

    Can we change it to CREATE UNIQUE INDEX
    
    it will mean inserting the same entry twice will fail.
    
    We shouldn't be doing that anyway, but it's good to have better integrity.
    
    --
    Given we have the if !tables().contains()
    
    we don't need the "if not exists"



contact-cache.cpp
<https://git.reviewboard.kde.org/r/115328/#comment34601>

    Long term I don't want to do this like this.
    
    We tend to only get given avatars if the user is currently online when we are. It would be good if we could make these persist across sessions.
    
    We can brainstorm how to fix this at a later date though.
    
    --
    One idea I've just had is
    we insert or update all the contacts we know about (taking care to preserve avatars) and also update a timestamp or counter or something. Then we delete all the items with an old counter.


- David Edmundson


On Feb. 4, 2014, 3:23 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115328/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 3:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Was: https://git.reviewboard.kde.org/r/115060/
> 
> Draft version. Not proposed to be merged as is.
> 
> TODO:
> * Fix code
> * Add groups info
> * Performance testing.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a31245b 
>   contact-cache.h PRE-CREATION 
>   contact-cache.cpp PRE-CREATION 
>   contactnotify.cpp 314d48a 
>   telepathy-module.cpp a754283 
> 
> Diff: https://git.reviewboard.kde.org/r/115328/diff/
> 
> 
> Testing
> -------
> 
> Tested accounts contact refreshing in follow action:
> 1 Does connect via Telepathy.
> 2 Checked that contacts added to db (via sqlite db viewer).
> 3 Disconnected in telepathy.
> 4 Connect via another IM software.
> 5 Removed few contacts.
> 6 Does connect via Telepathy.
> 7 Checked that there is only actual contacts in db (via sqlite db viewer).
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140205/d4d696a4/attachment-0001.html>