Review Request 115328: KTp-KDED: Save all persistent information on a contact to a database

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115328/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 9:23 p.m.)


Review request for Telepathy.


Changes
-------

DB: Created index on accountId, contactId.
DB: Fixed deletion of contacts of invalidated accounts.

Fixed coding style.
Removed odd ktp-cache-account property on contactManager.

Maded some refactor and cleanups.


Repository: ktp-kded-module


Description
-------

Was: https://git.reviewboard.kde.org/r/115060/

Draft version. Not proposed to be merged as is.

TODO:
* Fix code
* Add groups info
* Performance testing.


Diffs (updated)
-----

  CMakeLists.txt a31245b 
  contact-cache.h PRE-CREATION 
  contact-cache.cpp PRE-CREATION 
  contactnotify.cpp 314d48a 
  telepathy-module.cpp a754283 

Diff: https://git.reviewboard.kde.org/r/115328/diff/


Testing
-------

Tested accounts contact refreshing in follow action:
1 Does connect via Telepathy.
2 Checked that contacts added to db (via sqlite db viewer).
3 Disconnected in telepathy.
4 Connect via another IM software.
5 Removed few contacts.
6 Does connect via Telepathy.
7 Checked that there is only actual contacts in db (via sqlite db viewer).


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140204/52ecda85/attachment.html>